Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2025

Bumps actions/checkout from 4 to 5.

Release notes

Sourced from actions/checkout's releases.

v5.0.0

What's Changed

⚠️ Minimum Compatible Runner Version

v2.327.1
Release Notes

Make sure your runner is updated to this version or newer to use this release.

Full Changelog: actions/checkout@v4...v5.0.0

v4.3.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v4...v4.3.0

v4.2.2

What's Changed

Full Changelog: actions/checkout@v4.2.1...v4.2.2

v4.2.1

What's Changed

New Contributors

Full Changelog: actions/checkout@v4.2.0...v4.2.1

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

V5.0.0

V4.3.0

v4.2.2

v4.2.1

v4.2.0

v4.1.7

v4.1.6

v4.1.5

v4.1.4

v4.1.3

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 12, 2025
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-5 branch from 6ae8f96 to 2190f4c Compare September 3, 2025 19:34
@kriskowal
Copy link
Member

The new runner relies on JS primitives including at least Array.prototype.find that are not present in Node.js 18, 20, & 22. This will have to wait.

@kriskowal kriskowal closed this Sep 3, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 3, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/actions/checkout-5 branch September 3, 2025 20:53
@mhofman
Copy link
Contributor

mhofman commented Sep 4, 2025

@kriskowal how does the internal reliance of the checkout action on Node 24 affect our own choice of Node version ?

@kriskowal
Copy link
Member

@kriskowal how does the internal reliance of the checkout action on Node 24 affect our own choice of Node version ?

That’s a great question, and you’re right that it should not, and I would not expect it to given that we choose our version of node after checkout. Perhaps I’ve misattributed the cause. Could it be that we just need a newer version of the actions runtime?

      - name: Checkout
        uses: actions/checkout@v4

      # without this, setup-node errors on mismatched yarn versions
      - run: corepack enable

      - name: Use Node.js ${{ matrix.node-version }}
        uses: actions/setup-node@v4
        with:
          node-version: ${{ matrix.node-version }}
          cache: yarn

The only fact is actions/checkout@v5 fails tests due to the missing array method.

@kriskowal kriskowal requested a review from Copilot September 4, 2025 23:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the actions/checkout GitHub Action from version 4 to version 5 across all workflow files. This is a routine dependency update that brings the action up to the latest major version, which includes an update to use Node.js 24 and requires a minimum runner version of v2.327.1.

  • Updates actions/checkout from v4 to v5 across all GitHub workflow files
  • Maintains existing functionality while ensuring compatibility with the latest action version

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/typedoc-gh-pages.yml Updates checkout action version for documentation generation workflow
.github/workflows/depcheck.yml Updates checkout action version for dependency checking workflow
.github/workflows/ci.yml Updates checkout action version across multiple CI jobs (8 occurrences)
.github/workflows/browser-test.yml Updates checkout action version for browser testing workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kriskowal
Copy link
Member

@dependabot reopen

@dependabot dependabot bot reopened this Sep 4, 2025
@dependabot dependabot bot restored the dependabot/github_actions/actions/checkout-5 branch September 4, 2025 23:24
@kriskowal
Copy link
Member

kriskowal commented Sep 4, 2025

Oh, interesting. I completely misdiagnosed this. The problem only afflicts the MacOS XS tests. This can be addressed with a condition for those tests.

@kriskowal
Copy link
Member

This affects the benchmark tests because esvu can’t get xs on mac (fine on linux). Maybe worth a gander, @gibson042. Maybe we can drop esvu because we also have infrastructure for yarn test:xs that captures XS in the build cache and all that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants