-
Notifications
You must be signed in to change notification settings - Fork 80
feat(ses): handle iterator override #2993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+82
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
178c532
to
4173c22
Compare
naugtur
commented
Oct 15, 2025
7 tasks
2511eef
to
f394558
Compare
naugtur
commented
Oct 15, 2025
erights
reviewed
Oct 16, 2025
erights
reviewed
Oct 16, 2025
erights
reviewed
Oct 16, 2025
erights
reviewed
Oct 16, 2025
erights
reviewed
Oct 16, 2025
erights
reviewed
Oct 16, 2025
erights
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c1d48e1
to
d446906
Compare
naugtur
commented
Oct 16, 2025
erights
reviewed
Oct 16, 2025
erights
reviewed
Oct 16, 2025
d446906
to
155710f
Compare
155710f
to
e164bd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2992
Description
Adds an enablement to cover for override mistake on Iterator's
Symbol.iterator
key.Additionally, added symbols to override test setup in general.
Security Considerations
None I'm aware of
Scaling Considerations
no
Documentation Considerations
Testing Considerations
tests added
Compatibility Considerations
compatibility improved
Upgrade Considerations
Not a breaking change