Skip to content

Conversation

naugtur
Copy link
Member

@naugtur naugtur commented Oct 15, 2025

Most PRs should close a specific Issue. All PRs should at least reference one or more Issues. Edit and/or delete the following lines as appropriate (note: you don't need both refs and closes for the same one):

Closes: #2992

Description

Adds an enablement to cover for override mistake on Iterator's Symbol.iterator key.

Additionally, added symbols to override test setup in general.

Security Considerations

None I'm aware of

Scaling Considerations

no

Documentation Considerations

Testing Considerations

tests added

Compatibility Considerations

compatibility improved

Upgrade Considerations

Not a breaking change

@naugtur naugtur requested a review from erights October 15, 2025 10:16
@naugtur naugtur force-pushed the iterator-override-taming branch from 178c532 to 4173c22 Compare October 15, 2025 10:17
@naugtur naugtur force-pushed the iterator-override-taming branch 2 times, most recently from 2511eef to f394558 Compare October 15, 2025 10:52
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naugtur naugtur force-pushed the iterator-override-taming branch 3 times, most recently from c1d48e1 to d446906 Compare October 16, 2025 10:01
@naugtur naugtur force-pushed the iterator-override-taming branch from d446906 to 155710f Compare October 20, 2025 14:08
@naugtur naugtur force-pushed the iterator-override-taming branch from 155710f to e164bd0 Compare October 20, 2025 14:10
@naugtur naugtur merged commit 801f4c5 into master Oct 20, 2025
19 checks passed
@naugtur naugtur deleted the iterator-override-taming branch October 20, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Override mistake in Iterator

2 participants