Adds propidl.h #263
Closed
Adds propidl.h #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds most of the contents of propidl.h to comtypes. I have found that there is a lot of COM interfaces that use the IPropertyStore interface along with the PROPVARIANT structure. I thought it would be nice to include this in comtypes like the VARIANT structure has been added.
|
You're welcome to finish it if you believe it's useful for many use cases. As I understood the current release can go without it, right? |
|
Oh yeah the current release can go without a problem. There are a lot of interfaces and functions that use the PROPVARIANT structure. The goal for this is to make available the IPropertyStore interface which gets used in a whole lot of the Windows API. core audio, shell, portable devices, photos, function discovery, media engine... those kids of things. Here is a list of functions and interfaces that use the PROPVARIANT structure, This is not an exhaustive list bu it gives you a good idea of how often it is used in the Windows API. Functions (click to expand)
Interfaces (click to expand)
There are 1024 times PROPVARIANT is written in the Windows 10 SDK, there are 471 times IPropertyStore is used. |
|
If you still want to merge it (with the necessary modifications), please rebase it to the current master and run CI. (cc: @vasily-v-ryabov) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds most of the contents of propidl.h to comtypes. I have found that there is a lot of COM interfaces that use the IPropertyStore interface along with the PROPVARIANT structure. I thought it would be nice to include this in comtypes like the VARIANT structure has been added.
I have not finished yet and will be adding the
valueproperty to PROPVARIANT and also adding methods to interfaces as needed. I wanted to see if there is an interest in adding this functionality to comtypes before I spend the time to finish it up.