Skip to content

Add support for building to the wasm32-wasi target #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ereslibre
Copy link
Owner

WIP

ereslibre and others added 2 commits January 25, 2023 19:13
Implement an initial version of setjmp/longjmp that resorts on
the Asyncify pass from Binaryen's wasm-opt in order to instrument the
resulting php-cgi binary.
@ereslibre ereslibre marked this pull request as ready for review January 25, 2023 22:15
@ereslibre ereslibre marked this pull request as draft January 25, 2023 22:15
@ereslibre ereslibre closed this Jan 26, 2023
@ereslibre ereslibre deleted the wasm32-wasi-wip branch January 26, 2023 20:03
ereslibre pushed a commit that referenced this pull request Mar 3, 2023
…#10533)

Commit a211956 added a TSRM destructor, but that destructor
will get called by tsrm_shutdown(), which is after opcache.so has
already been unloaded, resulting in a shutdown crash, e.g.:

  #0  0x00007fad01737500 in ?? ()
  #1  0x000055ac54e723c4 in tsrm_shutdown () at TSRM/TSRM.c:194
  #2  0x000055ac54c42180 in main (argc=80, argv=0x55ac57bc14d0) at sapi/cli/php_cli.c:1388

By calling ts_free_id() before opcache.so gets unloaded, we can easily
fix this crash bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants