Skip to content

ToStr renamed to ToString #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2014
Merged

ToStr renamed to ToString #40

merged 2 commits into from
Jul 13, 2014

Conversation

drbawb
Copy link
Contributor

@drbawb drbawb commented Jul 11, 2014

This fixes a breaking change from rust. The ToStr trait, as well as its methods, were renamed.

Since the ToString trait was being used to implement Show for the Message type I renamed the method there as well.

Builds as of: rustc 0.11.0 (f9fe251777e9f1cc557a6d5b82b45403935d0a10)

drbawb added 2 commits July 11, 2014 08:44
@drbawb
Change to_str() -> to_string() where necessary
eb0a807 
* Alters several outdated uses of `to_str()`
* `Message::to_str()` renamed so `Message` continues to impl. `Show`
@drbawb
Update examples w/ change of to_str()
bd0b90b
erickt added a commit that referenced this pull request Jul 13, 2014
@erickt
Merge pull request #40 from drbawb/feature/to-str-rename
45fc259 
`ToStr` renamed to `ToString`
@erickt erickt merged commit 45fc259 into erickt:master Jul 13, 2014
@erickt
Copy link
Owner

erickt commented Jul 13, 2014

thanks!

@dshulyak dshulyak mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drbawb @erickt