Skip to content

implement PEP 554 for use in test suite #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ericsnowcurrently opened this issue Aug 24, 2018 · 6 comments
Open

implement PEP 554 for use in test suite #21

ericsnowcurrently opened this issue Aug 24, 2018 · 6 comments
Assignees
@ericsnowcurrently @nanjekyejoannah
Labels
complexity: low easy to figure out P1 medium priority size: small requires few changes type: code health X [stdlib API] exposing C impl in Python code X [testing]

Comments

@ericsnowcurrently
Copy link
Owner

ericsnowcurrently commented Aug 24, 2018 •
edited
Loading

Issue #22 is about making use of subinterpreters (specifically the PEP 554 API) in the CPython test suite.
Until PEP 554 is accepted (or if it isn't) we should add a PEP 554 implementation as Lib/test/support/_interpreters.py (e.g. test.support._interpreters).
@ericsnowcurrently ericsnowcurrently mentioned this issue Aug 24, 2018
Open
4 tasks
@ericsnowcurrently ericsnowcurrently added X [stdlib API] exposing C impl in Python code P1 medium priority type: code health size: small requires few changes complexity: low easy to figure out X [testing] labels Aug 24, 2018
@ericsnowcurrently ericsnowcurrently changed the title implement PEP 554 for use in test suite (i.e. test.support.interpreters) implement PEP 554 for use in test suite Aug 24, 2018
@ericsnowcurrently ericsnowcurrently self-assigned this Aug 24, 2018
@ericsnowcurrently ericsnowcurrently mentioned this issue Nov 8, 2019
Closed
@ericsnowcurrently
Copy link
Owner Author

@nanjekyejoannah, what's the status on this? IIRC you were blocked on a few other issues. I'm hoping we can get them resolved in the next week or so and then get this merged. What do you think?

@nanjekyejoannah
Copy link
Collaborator

nanjekyejoannah commented Apr 17, 2020 •
edited
Loading

@ericsnowcurrently, yes I have most of it working. I will need to take a day or two for final touches. I have exams this coming week till around 24th but I will be able to get the remaining work through after 24th. So we are talking about practically hearing from me by 28th. Is this fine?

@ericsnowcurrently
Copy link
Owner Author

Sounds good. Good luck on your exams! 😁

@nanjekyejoannah
Copy link
Collaborator

Blocked by this PR. I think @LewisGaul has looked at this longer. It makes sense for you to finish. @LewisGaul happy to know where to help.

@nanjekyejoannah nanjekyejoannah mentioned this issue Apr 25, 2020
Merged
@nanjekyejoannah
Copy link
Collaborator

@ericsnowcurrently I opened a PR to solve this here : python/cpython#19985

@ericsnowcurrently
Copy link
Owner Author

Awesome! I should have some time to look tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsnowcurrently ericsnowcurrently

@nanjekyejoannah nanjekyejoannah

Labels
complexity: low easy to figure out P1 medium priority size: small requires few changes type: code health X [stdlib API] exposing C impl in Python code X [testing]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericsnowcurrently @nanjekyejoannah