Skip to content

PEP 554: Minor typo in example code: create_fifo->create_channel #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dimitern opened this issue Nov 8, 2019 · 3 comments · Fixed by dimitern/peps#1 or #1230
Closed

PEP 554: Minor typo in example code: create_fifo->create_channel #1229

dimitern opened this issue Nov 8, 2019 · 3 comments · Fixed by dimitern/peps#1 or #1230

Comments

@dimitern
Copy link
Contributor

dimitern commented Nov 8, 2019

I found a minor typo here:
https://www.python.org/dev/peps/pep-0554/#passing-objects-via-marshal

In the example code for *Passing objects via marshal", I suspect perhaps an older version of the module API was used (create_fifo()):

interp = interpreters.create()
r, s = interpreters.create_fifo()

should most likely be:

interp = interpreters.create()
r, s = interpreters.create_channel()

Related comment link: ericsnowcurrently/multi-core-python#20 (comment)
Re: @ericsnowcurrently

I'm preparing a PR for the suggested change.

@ericsnowcurrently
Copy link
Member

Thanks for finding that, @dimitern! (and long time no see 😁️)

dimitern added a commit to dimitern/peps that referenced this issue Nov 8, 2019
PEP 554: Fix typo in marshal example code (python#1229)
@dimitern
Copy link
Contributor Author

dimitern commented Nov 8, 2019

@ericsnowcurrently I enjoyed your lightning talk on subinterpreters, looking forward to taking some for a spin! I'd be happy to help with test module changes if you can use some help. (I've been stuck on https://bugs.python.org/issue37584 for a while now)

@ericsnowcurrently
Copy link
Member

Thanks for the help, @dimitern. It's good to see you getting involved. :)

Yeah, I could definitely use help on my multi-core Python project. Pretty much all the work is being orchestrated through https://github.com/ericsnowcurrently/multi-core-python. The "projects" cover just about everything, and there's a wiki page on more general stuff. So take a look. You can also get in touch directly if you have specific questions. It's hard for me to otherwise know how you could help (and of course what might interest you).

At this point there isn't a ton to actually try out, though I suppose you could ask @nanjekyejoannah about taking her PEP 554 (Python module) implementation for a spin. I'm not volunteering her time though! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants