Closed
Description
Hi, vector-algorithms
have been crucial for competitive programming in Haskell. Huge thanks!
In version 0.9.0.3
, some functions are very slow. Examples:
Data.Vector.Algorithms
:Data.Vector.Algorithms.Intro
:sort
(marked asINLINABLE
, notINLINE
)
In va-bench
repository, I tried adding {-# INLINE #-}
pragmas and ran benchmarks. Here's a rough result:
1. Speed of intro sort
On VU.modify VAI.sort
, {-# INLINE sort #-}
makes it significantly faster:
2. Other sort functions
Other sort
functions should be marked as {-# INLINE #-}
, too:
3. nub
nub
and nubBy
should be marked as {-# INLINE #-}
. I guess nubByMut
should be at least marked as {-# INLINEABLE #-}
:
Metadata
Metadata
Assignees
Labels
No labels