Skip to content

Upgrade: eslint and other deps #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Upgrade: eslint and other deps #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c74b714
Upgrade: eslint v6
aladdin-add Apr 7, 2020
5ceb287
Upgrade: eslint v7
aladdin-add Apr 7, 2020
61f8246
Fix: no-deprecated-report-api error
aladdin-add Apr 7, 2020
b7173bf
Fix: require-meta-fixable reported error
aladdin-add Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ extends:
- plugin:self/all
root: true
rules:
comma-dangle:
- error
- arrays: always-multiline
objects: always-multiline
functions: never # disallow trailing commas in function(es2017)
require-jsdoc: error
self/meta-property-ordering: off
self/require-meta-docs-url: off
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@
"chai": "^4.1.0",
"dirty-chai": "^2.0.1",
"escope": "^3.6.0",
"eslint": "^5.9.0",
"eslint": "^7.0.0-alpha.3",
"eslint-config-not-an-aardvark": "^2.1.0",
"eslint-plugin-node": "^8.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-self": "^1.0.1",
"espree": "^4.1.0",
"estraverse": "^4.2.0",
"espree": "^6.2.1",
"estraverse": "^5.0.0",
"lodash": "^4.17.2",
"mocha": "^5.2.0"
"mocha": "^7.1.1"
},
"peerDependencies": {
"eslint": ">=5.0.0"
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-deprecated-report-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

const rule = require('../../../lib/rules/no-deprecated-report-api');
const RuleTester = require('eslint').RuleTester;
const ERROR = [{ message: 'Use the new-style context.report() API.', type: 'CallExpression' }];
const ERROR = { message: 'Use the new-style context.report() API.', type: 'Identifier' };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was caught by the new eslint v7. 🎉


// ------------------------------------------------------------------------------
// Tests
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/rules/require-meta-fixable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
const rule = require('../../../lib/rules/require-meta-fixable');
const RuleTester = require('eslint').RuleTester;

const MISSING_ERROR = [{ message: 'Fixable rules must export a `meta.fixable` property.', type: 'FunctionExpression' }];
const INVALID_ERROR = [{ message: '`meta.fixable` must be either `code`, `whitespace` or `null`.', type: 'Property' }];
const MISSING_ERROR = { message: 'Fixable rules must export a `meta.fixable` property.', type: 'FunctionExpression' };
const INVALID_ERROR = { message: '`meta.fixable` must be either `code`, `whitespace` or `null`.', type: 'Property' };

// ------------------------------------------------------------------------------
// Tests
Expand Down