Bug: `no-missing-import` doesn't use the require algorithm when TS has CJS `moduleResolution`?

[hakimio]

Environment

Node version: v20.13.1
npm version: v10.8.1
ESLint version: v9.11.1
eslint-plugin-n version: v17.10.3
Operating System: Windows 10

What rule do you want to report?

no-missing-import

What did you expect to happen?

The plugin should find imports from TS barrel files.

Participation

• I am willing to submit a pull request for this issue.

Additional comments

No response

[voxpelli]

Can you elaborate a bit on the "TS barrel files" and maybe point to some example or docs? There's barely any info in this issue, making it harder than it needs to be to act upon 🙏

[hakimio]

How to add Barrels in TypeScript

[voxpelli]

Right, that concept I’m aware of, not sure that’s the common name for it though, never really heard that term before.

Is this limited to TS or goes for all files that does that kind of thing?

And what error are you getting?

From the rule description:

This rule checks the file paths of import and export declarations

But “should find imports from TS barrel files” sounds like it’s not about paths in your case but about what’s imported? Path validation shouldn’t care if it’s a “barrel file” or non-barrel one

[hakimio]

Following throws errors for me:

import {Foo} from '../../foo/bar';

where bar is existing folder containing index.ts exports.

[voxpelli]

Right, then the issue is probably this:

You use TS-syntax that compiles to CommonJS syntax, since only CommonJS (require()) supports resolving ./something to ./something/index.js

ESM imports are required to include the full path, including file extensions.

Have you specified your tsconfig? https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/no-missing-import.md#tsconfigpath

[hakimio]

No, I am not using CommonJS anywhere in the application. I am using ESM everywhere and everything transpiles just fine.
ts-node for development and esbuild for production builds.
I am not using full paths (or extensions) anywhere and everything works.

[scagood]

Can you break this example using a barrel?

https://eslint-online-playground.netlify.app/#eNp1kM1uwyAQhF8FcbFUJXZ7ipKotz5A7yGVEKwtt2ZBBreuLL97F3DtqD8+GMR8M+wwcd+rqsUAfS0V+ErJUL56fuIwOtsHpix6+svAHllBS3Hmu+SBURrXQYZbk+ApgdKz8GHZzOreGlaUt/EtahjJs8b8oW2X360ReaziLPCXpG3zT2BWfnah09iFluQB35GlJK1uF3xpg1bDczc0Lea7xMLuXTrco+AC14E01HLoArsIZPRt5iXaXwSvOxmqHpQ1Bqis3hurhw4Ev+4EXuM0Tqo32cRXtUiTTDFM8PDpCDrR7ttAfBQ0vD+Bi1moWvCRSZao5WGz7eVYHsr7xbaJN00S9XAojxGL1Cxw5vMX0wG2aw==

(Just paste the new url here once you have it not working)

[hakimio]

[scagood]

So it's exactly what @voxpelli said:

You use TS-syntax that compiles to CommonJS syntax, since only CommonJS (require()) supports resolving ./something to ./something/index.js

ESM imports are required to include the full path, including file extensions.

You will need to specify the full path to the file path (including file extension)
Docs: Mandatory file extensions

So, this will error:
import { cat } from './interfaces';

And this will not:
const { cat } = require('./interfaces');

---

Edit:

There is also no way to change this currently:
https://github.com/eslint-community/eslint-plugin-n/blob/master/lib/util/import-target.js#L279-L286

[hakimio]

Ok, if TS code with barrel imports is not supported and there are no plans to introduce the support, feel free to close this as "won't fix".