chore!: Update node versions to align with eslint v9

[scagood]

What changes did you make?

This simply updates the CI and package.json to run the tests against the node versions that ESLint v9 supports

BREAKING CHANGE: Requires Node.js: ^18.18.0 || ^20.9.0 || >=21.1.0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (176e7cb).
Report is 25 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #484   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       661   +12     
  Branches       250       247    -3     
=========================================
+ Hits           649       661   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brettz9]

LGTM, but maybe someone on the core team should review this kind of breaking change.

[brettz9]

@aladdin-add , @MichaelDeBoey , @voxpelli : Hi there... not sure who to ping, but I figured someone on the core team should be reviewing breaking changes?

[voxpelli]

I’m 👍 on aligning engine range with ESLint 9

What have the other plugins in this org done? Such as plugin-n?

I have been meaning to propose a change like this for eslint-utils as well as that’s the main thing holding my PR there back eslint-community/eslint-utils#204

[voxpelli]

Should we align here as well? Supporting all the way back to ESLint 7 but only Node 18 and newer feels a bit odd

[scagood]

Yeah, this is what I did in the original PR (#471)

4db7f5d

But I think that making that a separate PR for the change log was a good idea 😀

[voxpelli]

Hi there... not sure who to ping, but I figured someone on the core team should be reviewing breaking changes?

Pinging me is very okay at least :)

The governance docs got stuck a bit with people having different views and as far as I remember no counter proposals being made, so we do not have a structured process for this yet.

Feel very free to give feedback on eslint-community/governance#1, either directly there or to me, would love to have a clear process for these kinds of things

[aladdin-add]

leaving it open to let @xjamundx merge breaking changes, when he thinks it's a good time to release a major. :)

[voxpelli]

leaving it open to let @xjamundx merge breaking changes, when he thinks it's a good time to release a major. :)

@aladdin-add Are you sure @xjamundx is still the one leading this module? I thought he handed it over to the ESLint Community because he wasn't interested in maintaining it anymore?

[aladdin-add]

ah, I didn't know that! Do you think we can release a major version now? Are there any other breaking changes that should be included?

[scagood]

Node 22.5.0 has struck again! I guess I can only wait for the action to work out that 22.5.1 has been released 🤔
(nodejs/node#53902)

[voxpelli]

Node 22.5.0 has struck again! I guess I can only wait for the action to work out that 22.5.1 has been released 🤔 (nodejs/node#53902)

If you tell it to use 22.5.1 specifically, then it will pass, but will have to be reverted before merging

[aladdin-add]

It's all green now! ✅

[ota-meshi]

It appears that the merge of this PR did not release successfully.
To release a major version, BREAKING CHANGE: must be included in the message footer, but this repository appears to have been configured to include only the PR title in the commit message, so BREAKING CHANGE: was not included.
I will revert this PR twice and try to release it.

https://github.com/semantic-release/semantic-release#commit-message-format

[github-actions]

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[aladdin-add]

it's already configured, not sure why not working as expected🤔:

[ota-meshi]

I just changed that settings to "Pull request title and description". 😅
Before that it was set to "Pull request title".

[voxpelli]

It appears that the merge of this PR did not release successfully. To release a major version, BREAKING CHANGE: must be included in the message footer

Doing feat!: should be enough? The conventional commit convention says that the ! indicates a breaking change? Does the semver release flow not support that?

(I would personally be in favor of switching to a release please flow, like in eslint-community/eslint-plugin-n#305, as that catches errors like this before release)