fix!: drop support for ESLint older than 8 #235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelDeBoey How does the auto-release handle the merge of two PR:s like this and #234? Will there be a double bump in the major version? |
MichaelDeBoey
requested changes
Oct 2, 2024
True, any opinion on the change itself? Or response to my question? :) |
|
@voxpelli To answer your question: you should create a separate branch (if it's called Once all breaking changes are done, you can merge the new branch into If you merge both PRs directly to main, it could be that you're release 2 major versions, depending on how quick you are |
|
Superseded by #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233
Companion PR to #234
Opted to not specify any specific minimum minor version for some reason:
peerDependencies#233 (comment) – either one of>=8.23.0,>=8.56.0,^8.57.0would make sense – but would require needless bumps by users of eslint-utilseslint-utilsthat requires a newer versionI guess
>=8.23.0could make sense as that's where the new flat config format was introduced, https://eslint.org/blog/2022/08/eslint-v8.23.0-released/, any opinions?