Skip to content

fix: error in expression character class with nested character class #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: error in expression character class with nested character class #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,7 @@ class RegExpParserState {
if (
node.type !== "CharacterClass" ||
(node.parent.type !== "Alternative" &&
node.parent.type !== "CharacterClass") ||
(this._expressionBuffer && node.elements.length > 0)
node.parent.type !== "CharacterClass")
) {
throw new Error("UnknownError")
}
Expand All @@ -540,10 +539,15 @@ class RegExpParserState {
this._node = parent

const expression = this._expressionBuffer
this._expressionBuffer = null
if (!expression) {
if (
expression?.parent !== (node as unknown as ExpressionCharacterClass)
) {
return
}
if (node.elements.length > 0) {
throw new Error("UnknownError")
}
this._expressionBuffer = null

// Replace with ExpressionCharacterClass.
const newNode: ExpressionCharacterClass = {
Expand Down
Loading