HardwareSerial::begin can't be called twice to change baud rate

[Imroy]

HardwareSerial::begin() creates a '_uart' object by calling uart_init(), but doesn't check to see if it has already been created. Thus it malloc's without freeing the old one first. And it doesn't respect whatever settings have already been made.

In my case, I just need to be able to change the baud rate after having swapped Serial to the alternative pins. I've modified begin() to allow changing settings on an existing _uart object, which appears to be how the original Arduino code is meant to be used. A much simpler change_baudrate() method is also possible.

[asetyde]

this malloc has not a free after ?

On 05 dic 2015, at 19:30, Ian Tester notifications@github.com wrote:

HardwareSerial::begin() creates a '_uart' object by calling uart_init(), but doesn't check to see if it has already been created. Thus it malloc's without freeing the old one first. And it doesn't respect whatever settings have already been made.

In my case, I just need to be able to change the baud rate after having swapped Serial to the alternative pins. I've modified begin() to allow changing settings on an existing _uart object, which appears to be how the original Arduino code is meant to be used. A much simpler change_baudrate() method is also possible.

—
Reply to this email directly or view it on GitHub #1155.

[drmpf]

I am currently using

  Serial.end();
  delay(10);
  Serial.begin(storage.baudRate);

to change baud rates