Skip to content

Add a workaround-delay in Serial.flush() #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2017
Merged

Add a workaround-delay in Serial.flush() #3714

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d66c58
Add a workaround-delay in Serial.flush()
WereCatf Oct 13, 2017
0f25996
Remove extraneous character
WereCatf Oct 13, 2017
3ef8c2d
Update HardwareSerial.cpp
WereCatf Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cores/esp8266/HardwareSerial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ void HardwareSerial::flush()
}

uart_wait_tx_empty(_uart);
//Workaround for a bug in serial not actually being finished yet
//Wait for 8 data bits, 1 parity and 2 stop bits, just in case
delayMicroseconds(1100000 / uart_get_baudrate(_uart) + 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your original comment in the issue said this worked:
delayMicroseconds((int)(1000000.0 / uart_get_baudrate(_uart) * 11 + 1))

There is a difference of a factor of 10. Which is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1000000 * 11 == 11000000. Nuff said.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but 1100000 != 11000000
I think your PR is missing a zero.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good catch. I don't know how that did happen.

}

size_t HardwareSerial::write(uint8_t c)
Expand Down