Skip to content

Conversation

Merikei
Copy link
Contributor

@Merikei Merikei commented Oct 6, 2025

Description:

Replaced with auto-generated more complete versions in https://esphome.io/automations/actions/#all-actions & #all-conditions which are auto-generated.
There are no references to the removed files anywhere else on the site and they contain no anchors.

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /components/index.rst when creating new documents for new components or cookbook.

@esphome esphome bot added the current label Oct 6, 2025
Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 4cc9e37
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/68e41ebff219540008ffe6e3
😎 Deploy Preview https://deploy-preview-5453--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

Deleted two documentation pages under content/automations/: all_actions.md and all_conditions.md, which previously listed automation actions and conditions across multiple domains. No code or API changes.

Changes

Cohort / File(s) Summary
Docs: Automations index removal
content/automations/all_actions.md, content/automations/all_conditions.md
Removed monolithic documentation pages enumerating all automation actions and conditions. No functional code affected.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Break apart automations doc #3957 — Splits the removed monolithic automations documentation into separate actions/conditions pages; operates on the same content area.

Suggested labels

current

Suggested reviewers

  • jesserockz

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely indicates the removal of the two automation documentation files and directly reflects the main change in the pull request by naming both file paths without superfluous information.
Description Check ✅ Passed The description explains that the removed files are superseded by auto-generated versions, includes links to the new documentation, and confirms there are no remaining references, which directly corresponds to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f43c509 and 4cc9e37.

📒 Files selected for processing (2)
  • content/automations/all_actions.md (0 hunks)
  • content/automations/all_conditions.md (0 hunks)
💤 Files with no reviewable changes (2)
  • content/automations/all_actions.md
  • content/automations/all_conditions.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Merikei Merikei marked this pull request as draft October 6, 2025 19:59
@Merikei
Copy link
Contributor Author

Merikei commented Oct 6, 2025

Actually, the deploy preview seems to not be happy with the removal. Converting to draft while I work out if they actually are required

⚠️ Data not found for branch: pull/5453/head
https://deploy-preview-5453--esphome.netlify.app/automations/actions/#all-actions

@Merikei
Copy link
Contributor Author

Merikei commented Oct 6, 2025

Yep That error is normal, for example the last merged PR has the same error
#5445
https://deploy-preview-5445--esphome.netlify.app/automations/actions/#all-actions

LGTM

@Merikei Merikei marked this pull request as ready for review October 6, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant