attachInterruptArg should take voidFuncPtrArg as argument #1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hreintke
changed the title
|
How could I have missed that? |
|
so sorry for the delay guys :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bertmelis
When working on an example for the FunctionalInterrupt, I took yours from GPIOInterrupt as base.
However, could not get it to run correctly.
I think the signature of attachInterruptArg is wrong.
With the patch from this PR it works as expected.
Can you take a look ?
PS : Did not notice when creating FunctionalInterrupt as that implements it's own attach.