Skip to content

FIX - AsyncUDP joinMulticastGroup does not work if interface is not specified #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2019
Merged

FIX - AsyncUDP joinMulticastGroup does not work if interface is not specified #2279

merged 1 commit into from
Jan 6, 2019

Conversation

forkineye
Copy link
Contributor

@forkineye forkineye commented Jan 5, 2019 •
edited
Loading

If joinMulticastGroup is used with the default tcpip_if of TCPIP_ADAPTER_IF_MAX, an ungraceful crash will occur. This modifies joinMulticastGroup to utilize igmp_joingroup instead of igmp_joingroup_netif when TCPIP_ADAPTER_IF_MAX is passed in so that all interfaces are iterated over and joined.

@me-no-dev me-no-dev merged commit a6e3b29 into espressif:master Jan 6, 2019
@me-no-dev
Copy link
Member

Thanks @forkineye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forkineye @me-no-dev