Skip to content

Change define "ttgo-t-watch.build.board=T-Watch" to "ttgo-t-watch.build.board=T_Watch" prevent "warning: ISO C99 requires whitespace after the macro name" #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sweetlilmre
Copy link
Contributor

The "-" in the board name causes a compiler warning when this is expanded to -DARDUINO_BOARD="T-Watch".
This pull request fixes those warnings by replacing the "-" with "_" and aligns with other board definitions.

Change define "ttgo-t-watch.build.board=T-Watch" to "ttgo-t-watch.build.board=T_Watch" prevent "warning: ISO C99 requires whitespace after the macro name"
@datacute
Copy link

@me-no-dev
Is it possible that the platformio builds are failing because platformio also needs to change the board definition, but platformio are waiting till this commit is merged? platformio/platform-espressif32#378

The build.board turns into a compile time define in the recipes in platform.txt e.g. in recipe.c.o.pattern
-DARDUINO_{build.board}
https://github.com/espressif/arduino-esp32/blob/master/platform.txt#L72

Defines are not allowed to have hyphens in their name.

T-Watch isn't the only board with an invalid build.board value

@me-no-dev
Copy link
Member

already fixed in another commit

@me-no-dev me-no-dev closed this Oct 1, 2020
@sweetlilmre sweetlilmre deleted the patch-1 branch November 26, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants