Skip to content

Fix makeWord parameter types in Arduino.h and WMath.cpp #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

Fix makeWord parameter types in Arduino.h and WMath.cpp #5230

merged 1 commit into from
Jun 9, 2021

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented May 31, 2021

Fixes #5229.

@dok-net dok-net mentioned this pull request May 31, 2021
Closed
@dok-net dok-net force-pushed the fix_5229 branch 2 times, most recently from 5bbd0c5 to b382c68 Compare May 31, 2021 13:00
@dok-net
WMath.cpp doesn't include Arduino.h, where makeWord(h, l) is declared…
cedf5fc 
…, common denominator type therefore is uint8_t, which is in use already in Arduino.h, too.
@me-no-dev me-no-dev merged commit 77f5044 into espressif:master Jun 9, 2021
@dok-net dok-net deleted the fix_5229 branch June 9, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align with ESP8266 and fix signature deviation between Arduino.h and WMath.cpp
2 participants
@dok-net @me-no-dev