Skip to content

[WiFiClient] Default connection timeout, when no timeout provided #5487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2021
Merged

[WiFiClient] Default connection timeout, when no timeout provided #5487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07c341c
Connect should have default timeout
cziter15 Aug 1, 2021
fd6dd66
Update WiFiClient.cpp
cziter15 Aug 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libraries/WiFi/src/WiFiClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <lwip/netdb.h>
#include <errno.h>

#define WIFI_CLIENT_DEF_CONN_TIMEOUT (3)
#define WIFI_CLIENT_MAX_WRITE_RETRY (10)
#define WIFI_CLIENT_SELECT_TIMEOUT_US (1000000)
#define WIFI_CLIENT_FLUSH_BUFFER_SIZE (1024)
Expand Down Expand Up @@ -207,7 +208,7 @@ void WiFiClient::stop()

int WiFiClient::connect(IPAddress ip, uint16_t port)
{
return connect(ip,port,-1);
return connect(ip,port,WIFI_CLIENT_DEF_CONN_TIMEOUT);
}
int WiFiClient::connect(IPAddress ip, uint16_t port, int32_t timeout)
{
Expand Down Expand Up @@ -278,7 +279,7 @@ int WiFiClient::connect(IPAddress ip, uint16_t port, int32_t timeout)

int WiFiClient::connect(const char *host, uint16_t port)
{
return connect(host,port,-1);
return connect(host,port,WIFI_CLIENT_DEF_CONN_TIMEOUT);
}
int WiFiClient::connect(const char *host, uint16_t port, int32_t timeout)
{
Expand Down