Fixes Cookie Case Sensitivity #7112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PilnyTomas
approved these changes
Aug 11, 2022
fvaryu
added a commit
to fvaryu/arduino-esp32
that referenced
this pull request
Aug 16, 2022
…linet::setCookie() headerValue.toLowCase(). (espressif#7112)(espressif#7076)
P-R-O-C-H-Y
approved these changes
Aug 16, 2022
earlephilhower
added a commit
to earlephilhower/arduino-pico
that referenced
this pull request
May 30, 2024
earlephilhower
added a commit
to earlephilhower/arduino-pico
that referenced
this pull request
May 30, 2024
earlephilhower
added a commit
to earlephilhower/arduino-pico
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Cookie Names and Value are case sensitive, but attibutes such as "Expires", "Max-Age", "Domain", "Path", "Secure", "HttpOnly" must be case insensitively matched. This PR fixes it in
HTTPClient::setCookie(String date, String headerValue)function.Tests scenarios
ESP32
Related links
Fixes #7076