Skip to content

Fixes the usage of sdkconfig to switch reset active high/low (EHM-48) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TiKoESoPe
Copy link
Contributor

Description

Changing "RESET GPIO config" in the menuconfig had no effect. See #44

Related

Fixes #44

Testing

I Tested it by changing the setting in menuconfig and measured if reset active high/low could be switched afterwards.


Checklist

Before submitting a Pull Request, please ensure the following:

  • [x ] 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 16, 2025
@github-actions github-actions bot changed the title Fixes the usage of sdkconfig to switch reset active high/low Fixes the usage of sdkconfig to switch reset active high/low (EHM-48) Apr 16, 2025
@mantriyogesh
Copy link
Collaborator

@TiKoESoPe thank you for the help and time to submit this change. However, does this reset pin active high or low does make any sense for general use?

We feel this could be removed, however if you feel this still make sense, we will surely pull your change.

@mantriyogesh
Copy link
Collaborator

@SohKamYung-Espressif ++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting of reset active high/low does is always low active (EHM-47)
3 participants