-
Notifications
You must be signed in to change notification settings - Fork 417
engine: Make execution requests a sidecar, take 2 #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
dc38b46
engine: extract execution requests from payload
rkrasiuk e305d78
add executionrequestsv to wordlist
rkrasiuk 37e6d8c
update engine_getPayloadV4
rkrasiuk 0c984cd
Merge branch 'main' into extract-execution-requests
mkalinin fb15e73
Make execution requests a sidecar, take 2
mkalinin 08093be
Turn executionRequests into a sequence of bytes
mkalinin c0ab5e1
Simplify wording
mkalinin 0524ed9
Clean up wordlist
mkalinin 892cd30
Applied suggestions by @marioevz
mkalinin 76eb2d2
Switch to the nested list representation
mkalinin 7a6cf59
Fix typo
mkalinin 0dae476
Apply suggestions from @lucassaldanha
mkalinin 3bf5431
Switch getPayloadV4 response to ExecutionPayloadV3
mkalinin e08292f
Replace hash with full executionRequests object for newPayloadV4
mkalinin aa2a1aa
Fix the newPayloadV4 note
mkalinin 810fc1e
Mention that requestType byte isn't part of encoding
mkalinin bbe74b6
Mention SSZ encoding in the executionRequests list
mkalinin 05cefa9
Apply suggestions from @lucassaldanha
mkalinin 8a9f51e
Update payload.yaml examples
mkalinin 48de028
Drop 32 bytes len from executionRequests definition
mkalinin f1ce8ce
engine: clarification on requests
lightclient File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,4 +66,3 @@ src | |
https | ||
forkchoiceupdatedresponsev | ||
exitv | ||
depositreceiptv |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.