-
Notifications
You must be signed in to change notification settings - Fork 182
feat(benchmark): add p256verify to worst compute tests #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(benchmark): add p256verify to worst compute tests #1744
Conversation
4fc2f8d
to
15c891d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, just one comment overall.
], | ||
id="bls12_fp_to_g2", | ||
), | ||
pytest.param( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is going to pass but the test is only going to test empty account calls because there's no precompile here prior to Prague.
We should test whether precompile_address
is in fork.precompiles()
, and if not just pytest.skip("Precompile not enabled")
at the start of the function.
15c891d
to
1247180
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for these :)
I checked the coverage lost and it makes sense: We are no longer calling empty accounts (the disabled precompiles in prior forks). |
ποΈ Description
Adding benchmark test for the
P256VERIFY
precompile contract.π Related Issues
Issue: #1734
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.