Skip to content

Conversation

LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Jul 1, 2025

πŸ—’οΈ Description

Add CALL/DELEGATECALL/STATICCALL/CODECALL opcode interaction with CLZ

πŸ”— Related Issues or PRs

Issue #1795

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Jul 1, 2025
@LouisTsai-Csie LouisTsai-Csie added fork:osaka Osaka hardfork type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Jul 1, 2025
@LouisTsai-Csie LouisTsai-Csie changed the title feat(CLZ): add call operation test case for CLZ feat(tests): add call operation test case for CLZ Jul 1, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic test, just a few minor comments. Thanks!

@LouisTsai-Csie
Copy link
Collaborator Author

@marioevz Thanks for review! I've updated accordingly

@LouisTsai-Csie LouisTsai-Csie requested a review from marioevz July 7, 2025 19:19
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment for this and it should be ready to merge!

The comment about the generator, we can spawn an independent issue and tackle it later since it's not a priority :)

@LouisTsai-Csie LouisTsai-Csie force-pushed the clz-call-op branch 2 times, most recently from a482d62 to 9a91ffe Compare July 29, 2025 12:52
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@marioevz
Copy link
Member

For the test case generator I created a tracking issue: ethereum/execution-specs#1574

But it's not priority IMO, we can leave this until after Osaka :)

@marioevz marioevz merged commit 5345c1a into ethereum:main Jul 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork:osaka Osaka hardfork type:test Type: Add/refactor fw unit tests; no fw or el client test case changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants