-
Notifications
You must be signed in to change notification settings - Fork 182
feat(tests): add call operation test case for CLZ #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic test, just a few minor comments. Thanks!
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
e22135a
to
1cadd86
Compare
@marioevz Thanks for review! I've updated accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment for this and it should be ready to merge!
The comment about the generator, we can spawn an independent issue and tackle it later since it's not a priority :)
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
a482d62
to
9a91ffe
Compare
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
9a91ffe
to
60efb18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
For the test case generator I created a tracking issue: ethereum/execution-specs#1574 But it's not priority IMO, we can leave this until after Osaka :) |
60efb18
to
fe1b3e0
Compare
ποΈ Description
Add
CALL
/DELEGATECALL
/STATICCALL
/CODECALL
opcode interaction with CLZπ Related Issues or PRs
Issue #1795
β Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.