Skip to content

Conversation

felix314159
Copy link
Collaborator

πŸ—’οΈ Description

This replaces the outdate PR #1587

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@LouisTsai-Csie
Copy link
Collaborator

@felix314159 I think they already update the tx gas limit to 2**24 here

@marioevz
Copy link
Member

I tried to fill the tests (with -m not slow) and there's some tests that now fail due to the gas limit reduction:

  • tests/static/state_tests/stCreateTest/createLargeResultFiller.yml
  • tests/static/state_tests/stEIP1559/baseFeeDiffPlacesFiller.yml
  • tests/static/state_tests/stEIP1559/gasPriceDiffPlacesFiller.yml
  • tests/static/state_tests/stEIP1559/outOfFundsFiller.yml
  • tests/static/state_tests/stEIP1559/outOfFundsOldTypesFiller.yml
  • tests/static/state_tests/stRevertTest/costRevertFiller.yml
  • tests/static/state_tests/stShift/shiftSignedCombinationsFiller.yml
  • tests/static/state_tests/VMTests/vmIOandFlowOperations/gasFiller.yml
  • tests/static/state_tests/VMTests/vmIOandFlowOperations/msizeFiller.yml

I fixed two in the last two commits to get things started:

  • Skip tstore ddos tests skips tests in 15_tstoreCannotBeDosdFiller.yml and 21_tstoreCannotBeDosdOOOFiller.yml due to them now being addressed in the benchmark tests tests/benchmark/test_worst_compute.py::test_worst_tstore, but I had to create an issue to track a simple update that has to be made to the test in order to fully cover what the static tests were doing.
  • Split CREATE2_FirstByte_loopFiller.yml modifies CREATE2_FirstByte_loopFiller.yml to be split in three transactions in order to keep the gas limit below the new max, and keep the test verification working.

PTAL at those two examples, and I think the rest of the failing tests also need to be fixed with either of these two methods.

@marioevz
Copy link
Member

marioevz commented Jul 24, 2025

I created an issue to track failing tests from my last comment so we can:

  • Remove changes to any of these tests from this PR
  • Remove changes to any test in folder stTimeConsuming, since these will be deleted anyway
  • Merge this PR

@felix314159

@felix314159 felix314159 force-pushed the static-filler-maxgas branch from 6cdc920 to 7e29953 Compare July 25, 2025 09:09
@felix314159
Copy link
Collaborator Author

I created an issue to track failing tests from my last comment so we can:

* Remove changes to any of these tests from this PR

* Remove changes to any test in folder `stTimeConsuming`, since these will be deleted anyway

* Merge this PR

@felix314159

Done, let's get this merged and then try to fix the rest:

* tests/static/state_tests/stCreateTest/createLargeResultFiller.yml
* tests/static/state_tests/stEIP1559/baseFeeDiffPlacesFiller.yml
* tests/static/state_tests/stEIP1559/gasPriceDiffPlacesFiller.yml
* tests/static/state_tests/stEIP1559/outOfFundsFiller.yml
* tests/static/state_tests/stEIP1559/outOfFundsOldTypesFiller.yml
* tests/static/state_tests/stRevertTest/costRevertFiller.yml
* tests/static/state_tests/stShift/shiftSignedCombinationsFiller.yml
* tests/static/state_tests/VMTests/vmIOandFlowOperations/gasFiller.yml
* tests/static/state_tests/VMTests/vmIOandFlowOperations/msizeFiller.yml

as described in #1948

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 2920953 into ethereum:main Jul 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants