-
Notifications
You must be signed in to change notification settings - Fork 182
src(partial blob response): Framework changes and test added for unavailable blob situations #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src(partial blob response): Framework changes and test added for unavailable blob situations #2072
Conversation
Have not reviewed yet, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Only a couple of comments, and I will try to fix the execute-fill-forks plugin issues in a separate PR today so we don't encounter issues that require modifying the resolver like the one here in the future.
aa31d0c
to
8a14e34
Compare
Edit: fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments, and the branch needs a simple rebase to main, but should be ready.
0a7ae20
to
6ad89a0
Compare
Applied your proposed changes and rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for this!
ποΈ Description
This is a prototype, lmk what you think. I couldn't locally test these changes without changed the spec-evm-resolver version, but maybe it works without somehow. I locally test this running
go run . --docker.buildoutput --client=go-ethereum --client-file=clients_pectra.yaml --dev --loglevel=5
and
uv run execute hive ./tests/osaka/eip7594_peerdas/test_get_blobs.py::test_get_blobs --fork=osaka -vv -s
(this still works) oruv run execute hive ./tests/osaka/eip7594_peerdas/test_get_blobs.py::test_get_blobs_nonexisting --fork=osaka -vv -s
(wip)π Related Issues or PRs
N/A.
β Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.