Skip to content

Conversation

felix314159
Copy link
Collaborator

@felix314159 felix314159 commented Aug 22, 2025

πŸ—’οΈ Description

This is a prototype, lmk what you think. I couldn't locally test these changes without changed the spec-evm-resolver version, but maybe it works without somehow. I locally test this running
go run . --docker.buildoutput --client=go-ethereum --client-file=clients_pectra.yaml --dev --loglevel=5
and
uv run execute hive ./tests/osaka/eip7594_peerdas/test_get_blobs.py::test_get_blobs --fork=osaka -vv -s (this still works) or
uv run execute hive ./tests/osaka/eip7594_peerdas/test_get_blobs.py::test_get_blobs_nonexisting --fork=osaka -vv -s (wip)

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@marioevz
Copy link
Member

Have not reviewed yet, but JSONRPCError(code=-32000, message=address already reserved) means, specifically for go-ethereum, that the signer of the transaction has one already in the mempool for either blob or non-blob type, and we are trying to send another transaction the other type.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Only a couple of comments, and I will try to fix the execute-fill-forks plugin issues in a separate PR today so we don't encounter issues that require modifying the resolver like the one here in the future.

@felix314159 felix314159 force-pushed the blob-partial-responses-forbidden branch from aa31d0c to 8a14e34 Compare August 26, 2025 12:22
@felix314159
Copy link
Collaborator Author

felix314159 commented Aug 26, 2025

Have not reviewed yet, but JSONRPCError(code=-32000, message=address already reserved) means, specifically for go-ethereum, that the signer of the transaction has one already in the mempool for either blob or non-blob type, and we are trying to send another transaction the other type.

Edit: fixed

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, and the branch needs a simple rebase to main, but should be ready.

@felix314159 felix314159 force-pushed the blob-partial-responses-forbidden branch from 0a7ae20 to 6ad89a0 Compare August 28, 2025 10:20
@felix314159
Copy link
Collaborator Author

Applied your proposed changes and rebased on main

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks for this!

@marioevz marioevz merged commit 1b7092c into ethereum:main Aug 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants