Skip to content

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 29, 2025

πŸ—’οΈ Description

The P256 curve has two points with x coordinate being 0 (and none points with y being 0). Add two positive test cases where the points with 0 x-coordinate are public keys.

πŸ”— Related Issues or PRs

#2194

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

The P256 curve has two points with `x` coordinate being `0`
(and none points with `y` being `0`). Add two positive test cases
where the points with `0` x-coordinate are public keys.
@spencer-tb spencer-tb self-requested a review September 29, 2025 17:47
@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature labels Sep 29, 2025
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Passing on all ELs! Thanks!

@spencer-tb spencer-tb merged commit a5f0b21 into ethereum:main Sep 29, 2025
15 checks passed
@chfast chfast deleted the tests/p256_x0 branch September 30, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants