Skip to content

Incorrect Error Number on Invalid Withdrawals Value for NewPayloadV2, ForkchoiceUpdatedV2  #26584

@marioevz

Description

@marioevz

System information

Geth version: Geth/v1.11.0-unstable-5c8cc10d-20230201/linux-amd64/go1.19.5
CL client & version: Hive
OS & Version: Linux
Commit hash : 5c8cc10

Expected behaviour

Pre-Shanghai payloads with withdrawals or Post-Shanghai payloads with null-withdrawals in engine_newPayloadV2 must fail with error -32602.

Actual behaviour

Different error code:

{"jsonrpc":"2.0","id":1,"error":{"code":-38003,"message":"Invalid payload attributes","data":{"err":"withdrawals before shanghai"}}}

Same issue for engine_forkchoiceUpdatedV2 on the withdrawals field in payload attributes.

It's a very minor issue but hive tests are failing because of this.

Steps to reproduce the behaviour

./hive --client go-ethereum --sim ethereum/engine --sim.limit "engine-withdrawals/Withdrawals Fork on Block 3" --docker.nocache go-ethereum

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions