Skip to content

github: reinstate swarm codeowners to p2p package submodules #18466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

github: reinstate swarm codeowners to p2p package submodules #18466

merged 1 commit into from
Jan 22, 2019

Conversation

acud
Copy link
Member

@acud acud commented Jan 17, 2019

This PR reinstates swarm codeowners to the p2p package submodules that are managed by the team

@acud acud self-assigned this Jan 17, 2019
@acud acud requested review from nonsense, janos and zelig January 17, 2019 02:08
janos
janos reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that I should be listed here. I did not contribute to p2p packages, except maybe with some small fixes.

@acud acud force-pushed the codeowners-galore branch from da8ab59 to c073bf9 Compare January 22, 2019 09:28
@nonsense nonsense merged commit a6e0285 into ethereum:master Jan 22, 2019
@frncmx frncmx deleted the codeowners-galore branch January 22, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zelig zelig Awaiting requested review from zelig

3 more reviewers

@nonsense nonsense nonsense approved these changes

@janos janos janos approved these changes

@frncmx frncmx frncmx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@acud acud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acud @nonsense @janos @frncmx