Skip to content

accounts/abi/bind: fixed unpacking error #22230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

accounts/abi/bind: fixed unpacking error #22230

merged 1 commit into from
Feb 10, 2021

Conversation

MariusVanDerWijden
Copy link
Member

There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching from regular casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct

closes #22219

@MariusVanDerWijden
accounts/abi/bind: fixed unpacking error
1232d77 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gballet
gballet approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gballet gballet added this to the 1.10.0 milestone Feb 10, 2021
@gballet gballet merged commit cb3c7e4 into ethereum:master Feb 10, 2021
renaynay pushed a commit to renaynay/go-ethereum that referenced this pull request Feb 16, 2021
@MariusVanDerWijden @renaynay
accounts/abi/bind: fixed unpacking error (ethereum#22230)
6d20fdc 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
filipescuc pushed a commit to EthereumGenesys/go-ethereum that referenced this pull request Mar 2, 2021
@MariusVanDerWijden @cfilipescu
accounts/abi/bind: fixed unpacking error (ethereum#22230)
fea0c6f 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
@connorwstein connorwstein mentioned this pull request Mar 31, 2021
Merged
@quorumbot quorumbot mentioned this pull request Sep 3, 2021
Merged
9 tasks
@baptiste-b-pegasys baptiste-b-pegasys mentioned this pull request Sep 3, 2021
Closed
9 tasks
This was referenced Sep 23, 2022
Closed
Merged
@JayChoi1736 JayChoi1736 mentioned this pull request Nov 1, 2023
Merged
9 tasks
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 7, 2025
@MariusVanDerWijden @gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
5b3a2e8 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 7, 2025
@MariusVanDerWijden @gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
426e8b6 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 8, 2025
@MariusVanDerWijden @gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
1fb784e 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 9, 2025
@MariusVanDerWijden @gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
4d83ebe 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@MariusVanDerWijden @gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
42cff0b 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@MariusVanDerWijden @gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
561249b 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@MariusVanDerWijden @gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
5fb2f48 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@MariusVanDerWijden @gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
4a8416e 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 14, 2025
@gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
5024760 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 16, 2025
@gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
90d53a0 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 17, 2025
@gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
81a8110 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
0c23562 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
966d0ac 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 23, 2025
@gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
3e2df30 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 24, 2025
@gzliudan
accounts/abi/bind: fixed unpacking error (ethereum#22230)
01d3be7 
There was a dormant error with structured inputs that failed unpacking.
This commit fixes the error by switching casting to the better abi.ConvertType function.
It also adds a test for calling a view function that returns a struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet gballet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Abigen v1.9.25 bytes32 interface conversion bug
2 participants
@MariusVanDerWijden @gballet