Skip to content

Conversation

rjl493456442
Copy link
Member

No description provided.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minor nit)

Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Martin Holst Swende <[email protected]>
@holiman holiman added this to the 1.11.0 milestone Dec 13, 2022
@holiman
Copy link
Contributor

holiman commented Dec 13, 2022

Sorry, something about my comment is not approved by the linter, for some reason

core/state/statedb.go:209: File is not `goimports`-ed (goimports)
// GetLogs returns the logs matching the specified transaction hash, and annotates them with the given blocknumber/blockhash

@holiman holiman merged commit cda051e into ethereum:master Dec 13, 2022
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
* core, cmd: fill blockNumber in logs

* Update core/state/statedb.go

Co-authored-by: Martin Holst Swende <[email protected]>

* core/types: revert

* core/state: improve comments

Co-authored-by: Martin Holst Swende <[email protected]>
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 10, 2025
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants