Skip to content

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented May 24, 2023

similar to #27329

@s1na
Copy link
Contributor

s1na commented May 24, 2023

>>> build/cache/golangci-lint-1.51.1-linux-amd64/golangci-lint run --config .golangci.yml ./...
core/types/block.go:1: : # github.com/ethereum/go-ethereum/core/types [github.com/ethereum/go-ethereum/core/types.test]
core/types/log_test.go:21:2: "fmt" imported and not used
core/types/log_test.go:100:14: undefined: errors (typecheck)
// Copyright 2014 The go-ethereum Authors
core/types/hashing_test.go:30:2: could not import github.com/ethereum/go-ethereum/core/types (-: # github.com/ethereum/go-ethereum/core/types [github.com/ethereum/go-ethereum/core/types.test]
core/types/log_test.go:21:2: "fmt" imported and not used
core/types/log_test.go:100:14: undefined: errors) (typecheck)
	"github.com/ethereum/go-ethereum/core/types"
	^
util.go:48: exit status 1

jsvisa added 2 commits May 24, 2023 21:10
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
@holiman holiman added this to the 1.12.1 milestone May 25, 2023
@holiman holiman merged commit 6c73276 into ethereum:master May 25, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
* core: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* console: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* core: go autoimport

Signed-off-by: jsvisa <[email protected]>

* core: dry

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa jsvisa deleted the core-errorf branch November 7, 2024 02:04
sobolev-igor pushed a commit to zeriontech/go-ethereum that referenced this pull request Sep 8, 2025
* core: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* console: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <[email protected]>

* core: go autoimport

Signed-off-by: jsvisa <[email protected]>

* core: dry

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants