eth/filters, core/rawdb: remove unused param, refactor filtering-loop #27891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
requested review from
MariusVanDerWijden,
gballet,
karalabe and
rjl493456442
as code owners
rjl493456442
approved these changes
Aug 10, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ethereum#27891) This change removes a chainconfig parameter passed into rawdb.ReadLogs, which is not used nor needed. It also modifies the filter loop slightly, avoiding a labeled break and instead using a method. This change does not modify any behaviour.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ing-loop (ethereum#27891)" This reverts commit 489b7c8.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ing-loop (ethereum#27891)" This reverts commit 489b7c8.
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Feb 26, 2024
27891 remove chainconfig param from ReadLogs. Removing this param from our code required using ReadRawReceipts, and filling the missing log fields that ReadReceipts does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a chainconfig parameter passed into
rawdb.ReadLogs, which is not used nor needed.It also modifies the filter loop slightly, avoiding a labeled break and instead using a method.
None of the changes in this PR (intentionally) modify behaviour.