-
Notifications
You must be signed in to change notification settings - Fork 21.4k
eth/tracers/js: use t.toBig on ctx.GasPrice for js tracing #27903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
holiman
merged 1 commit into
ethereum:master
from
nettijoe96:nettijoe/gas_price_js_tracer
Aug 15, 2023
Merged
eth/tracers/js: use t.toBig on ctx.GasPrice for js tracing #27903
holiman
merged 1 commit into
ethereum:master
from
nettijoe96:nettijoe/gas_price_js_tracer
Aug 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch!
rjl493456442
approved these changes
Aug 14, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…27903) This change fixes a bug in js tracer, where `ctx.GasPrice.toString(16)` returns a number string in base `10`.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27903)" This reverts commit 77b5584.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27903)" This reverts commit 77b5584.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2025
…7903 This change fixes a bug in js tracer, where `ctx.GasPrice.toString(16)` returns a number string in base `10`.
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 13, 2025
…7903 This change fixes a bug in js tracer, where `ctx.GasPrice.toString(16)` returns a number string in base `10`.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2025
…7903 This change fixes a bug in js tracer, where `ctx.GasPrice.toString(16)` returns a number string in base `10`.
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Sep 9, 2025
…7903 (#1341) This change fixes a bug in js tracer, where `ctx.GasPrice.toString(16)` returns a number string in base `10`. Co-authored-by: Joe Netti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in js tracer,
ctx.GasPrice.toString(16)
returns a number string in base 10.