cmd, core, miner: add extradata validation to consensus rules #2794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Sat Jul 16 10:09:55 UTC 2016 |
1 task
| if self.config.DAOForkSupport { | ||
| header.Extra = common.CopyBytes(params.DAOForkBlockExtra) | ||
| } else if bytes.Compare(header.Extra, params.DAOForkBlockExtra) == 0 { | ||
| header.Extra = []byte{} // If miner opposes, don't let it use the reserved extra-data |
There was a problem hiding this comment.
The intent is that a non-forking user might set extra-data from the command line to the one used by forkers, just to wreck havok in the "other" camp. This is just a check to remove naive attempts at that. It's not a fool proof solution of course, just a nicety to try and prevent people doing bad things with little effort.
|
Superseeded and merged in #2814. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite PRs, merge these first to get rid of duplicate commits:
This PR makes the necessary consensus modifications to header validation rules so that block header
extraDatafields are enforced to be either0x64616f2d686172642d666f726b(hex fordao-hard-fork) for pro-forkers or everything but that for non-forkers. These rules are upheld for10blocks straight to protect both forkers and non-forkers against malicious actors of the opposite side.Since non-forkers also need to know the actual DAO hard-fork block number to enforce themselves onto the opposite side of the network (i.e. a non-forker fast syncing needs to be aware of the headers it needs to check), this PR makes a further modification to the previous chain configurations so not only a single
ChainConfig.DAOForkNumberis maintained (previously implicitly signalling pro-fork), but rather an explicitChainConfig.DAOForkSupportboolean flag is added too. This way both camps can maintain the block numbers whilst also allowing both decisions.