Skip to content

trie: fix random test generator early terminate #28590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2023
Merged

trie: fix random test generator early terminate #28590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca92e9
trie: fix random test generator early terminate
weiihann Nov 23, 2023
bd3deae
Update trie_test.go
holiman Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion trie/trie_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,9 @@ func TestRandomCases(t *testing.T) {
// Instances of this test are created by Generate.
type randTest []randTestStep

// compile-time interface check
var _ quick.Generator = (randTest)(nil)

type randTestStep struct {
op int
key []byte // for opUpdate, opDelete, opGet
Expand All @@ -394,7 +397,7 @@ const (
func (randTest) Generate(r *rand.Rand, size int) reflect.Value {
var finishedFn = func() bool {
size--
return size > 0
return size == 0
}
return reflect.ValueOf(generateSteps(finishedFn, r))
}
Expand Down