ethclient: allow use the old "data" field if explicitly required #29046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
force-pushed
the
allow_use_data
branch
from
6d0a352 to
3f42a2a
Compare
zhiqiangxu
force-pushed
the
allow_use_data
branch
from
3f42a2a to
972c574
Compare
|
Feel free to pin old ethclients in your dependencies if you need the old behavior. The data vs input debate was 7 years ago, can't hang onto it forever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
go-ethereumhas many forks, which may not have incorporated the change of using "input" field instead of the old "data" field introduced here.This PR allows the user to use the "data" field in those situations.