Skip to content

eth/protocols/eth,p2p/discover: remove unnecessary checks #29590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

undefinedor
Copy link
Contributor

No description provided.

@undefinedor undefinedor changed the title fix useless condition eth/protocols/eth,p2p/discover: fix useless condition Apr 20, 2024
@undefinedor undefinedor force-pushed the bugfix/fix-useless-condition branch from 6d2b15b to 959633f Compare April 23, 2024 17:18
@undefinedor
Copy link
Contributor Author

@holiman I have already reverted.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman changed the title eth/protocols/eth,p2p/discover: fix useless condition eth/protocols/eth,p2p/discover: remove unnecessary checks Apr 25, 2024
@holiman holiman merged commit a13b925 into ethereum:master Apr 25, 2024
3 checks passed
@holiman holiman added this to the 1.14.1 milestone Apr 25, 2024
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
stwiname pushed a commit to subquery/data-node-go-ethereum that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants