[wip] implement FILL_COST #30201
Draft
[wip] implement FILL_COST #30201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Jul 22, 2024
| func (s *StateDB) IsSlotFilled(addr common.Address, slot common.Hash) bool { | ||
| // The snapshot can not be used, because it uses the old encoding where | ||
| // no difference is made between 0 and no data. | ||
| _, err := s.db.DiskDB().Get(utils.StorageSlotKeyWithEvaluatedAddress(s.accessList.pointCache.GetTreeKeyHeader(addr[:]), slot[:])) |
There was a problem hiding this comment.
should go through the reader abstaction, because it might have been written in a previous block but not in the db / also we want to use the layers to build the witness if we can.
There was a problem hiding this comment.
@rjl493456442 s.reader.StorageExist(addr, slot)
gballet
commented
Jul 29, 2024
| ae.touchAddressAndChargeGas(addr, zeroTreeIndex, utils.CodeSizeLeafKey, false) | ||
| func (ae *AccessEvents) AddTxDestination(addr common.Address, sendsValue, isFill bool) { | ||
| ae.touchAddressAndChargeGas(addr, zeroTreeIndex, utils.VersionLeafKey, false, false) | ||
| ae.touchAddressAndChargeGas(addr, zeroTreeIndex, utils.BalanceLeafKey, sendsValue, isFill) |
There was a problem hiding this comment.
@jsign correctly points out that if isFill is true, then the whole account will be created.
gballet
commented
Jul 29, 2024
| statelessGas += evm.AccessEvents.BalanceGas(contractAddr, true, false) | ||
| if contractAddr != beneficiaryAddr { | ||
| statelessGas += evm.AccessEvents.BalanceGas(beneficiaryAddr, true) | ||
| statelessGas += evm.AccessEvents.BalanceGas(beneficiaryAddr, true, !evm.StateDB.Exist(beneficiaryAddr)) |
There was a problem hiding this comment.
same point by @jsign : the account will need to be created so the fill might be more than just the balance
There was a problem hiding this comment.
this one should be fixed by just charging the empty code hash as well from here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILL_COSTis currently missing from every verkle testnet owing to the difficulty of knowing that a slot already existed. This is the implementation of the feature, trying to get the information from context as much as possible instead of recovering it from the database.