internal/ethapi: add transient storage override support for eth_call #32680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero5512
force-pushed
the
override-transient-storage
branch
from
83a8465 to
720946f
Compare
|
@s1na do these types of overrides need to be represented in rpc specs? |
|
@hero5512 this is still a draft - is that intentional? |
Yes, there are still some issues with this PR. |
|
@s1na This pr is ready to review. Please take a look. |
@lightclient The good: they are all standardized as part of eth_simulateV1 The bad: not specified in the specs for eth_call and eth_estimateGas The ugly: I think only geth and reth support them in eth_call and eth_estimateGas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr implements #32671, adding an override for the transient storage function in eth_call.