Skip to content

Conversation

lightclient
Copy link
Member

Currently --override.osaka doesn't work because it only overrides with the provided time, but does not provide a blob schedule. Since the blob schedule isn't provided on any network yet, it will fail to start. Even after we add the Osaka blob schedule to the default networks, it usefulness is very limited since 1) it alone cannot change the max or target for the fork and 2) there are several BPOs scheduled alongside Osaka with their own max and targets - none of which can be overridden yet.

For those reasons, I propose removing the OverrideOsaka flag and pursue a complete / future-proof solution such as #32556.

@rjl493456442
Copy link
Member

To clarify, the current override mechanism is limited to modifying fork timestamps
and cannot change other fork parameters.

Given that the primary use case is expected to be timestamp adjustment (e.g.,
manually delay a fork activation), I think we should keep this mechanism for now.
A more comprehensive solution can be introduced later for replacement?

@lightclient
Copy link
Member Author

That's correct. But even just limiting to the timestamp, we don't have any of the 5 BPOs implemented with an override. And each would require we add the blob schedule somehow when we override. This also currently isn't implemented.

So IMO if we keep the Osaka override we have some additional things to add and we give ourselves permanent responsibility of churning these override flags. It made sense to me when it was occasional and one at a time, but now I think #32556 is a better solution going forward.

@fjl fjl added this to the 1.16.5 milestone Sep 23, 2025
@lightclient lightclient force-pushed the geth-rm-override-osaka branch from 0c7fd66 to 0255f3f Compare September 25, 2025 13:09
@lightclient lightclient changed the title all: remove OverrideOsaka flag all: remove osaka and bpo override flags Sep 25, 2025
@lightclient
Copy link
Member Author

Updated to remove BPO flags also :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants