simulators/engine: Fix re-org tests #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [2.1.0](ethpandaops/ethereum-package@2.0.0...2.1.0) (2024-03-28) ### Features * add beacon snooper ([ethereum#520](ethpandaops/ethereum-package#520)) ([7e36191](ethpandaops/ethereum-package@7e36191)) * add BN<>CL compatibility matrix to readme ([ethereum#519](ethpandaops/ethereum-package#519)) ([177beeb](ethpandaops/ethereum-package@177beeb)) * add grandine ([ethereum#517](ethpandaops/ethereum-package#517)) ([3ac4d2a](ethpandaops/ethereum-package@3ac4d2a)) * enable preset to be set, mainnet/minimal ([ethereum#524](ethpandaops/ethereum-package#524)) ([f6e1b13](ethpandaops/ethereum-package@f6e1b13)) * make deneb genesis default ([ethereum#518](ethpandaops/ethereum-package#518)) ([49509b9](ethpandaops/ethereum-package@49509b9)) * make keymanager optional ([ethereum#523](ethpandaops/ethereum-package#523)) ([969012c](ethpandaops/ethereum-package@969012c)) * update verkle genesis + add besu support to verkle testing ([ethereum#512](ethpandaops/ethereum-package#512)) ([0615cd1](ethpandaops/ethereum-package@0615cd1)) ### Bug Fixes * architecture.md ([ethereum#514](ethpandaops/ethereum-package#514)) ([f0ec4f0](ethpandaops/ethereum-package@f0ec4f0)) * blobscan network name ([ethereum#516](ethpandaops/ethereum-package#516)) ([83c2a55](ethpandaops/ethereum-package@83c2a55)) * **blobscan:** update healthcheck endpoint ([ethereum#513](ethpandaops/ethereum-package#513)) ([8b2fc61](ethpandaops/ethereum-package@8b2fc61)) * separate vc ([ethereum#526](ethpandaops/ethereum-package#526)) ([baa04e9](ethpandaops/ethereum-package@baa04e9)) * Updated Readme with VCs supported by Grandine BN ([ethereum#527](ethpandaops/ethereum-package#527)) ([9cbe0b3](ethpandaops/ethereum-package@9cbe0b3)) * use correct dora & assertoor images ([ethereum#522](ethpandaops/ethereum-package#522)) ([2a8d73a](ethpandaops/ethereum-package@2a8d73a)) * use new validator names in assertoor config ([ethereum#521](ethpandaops/ethereum-package#521)) ([f595eb9](ethpandaops/ethereum-package@f595eb9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Engine API tests that perform a re-org, in order to ensure that the forkchoiceUpdated directive always points to a side-chain and does not attempt to jump back and forth to previous blocks on the canonical chain.
However, a simple sanity test is added which performs this behavior, but in this case the test simply expects that the client does not fail and is capable of progressing after such event.