Skip to content

use all VMs in test_opcodes #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
carver opened this issue May 3, 2019 · 0 comments
Open

use all VMs in test_opcodes #1774

carver opened this issue May 3, 2019 · 0 comments

Comments

@carver
Copy link
Contributor

carver commented May 3, 2019

What is wrong?

Looks related to #1111

Right now, a number of VMs are hard-coded into explicit opcode tests. This means that newer VMs were not being tested.

How can it be fixed

Use the VM fixture to iterate over all VMs (See example in #1773 )
carver added a commit to carver/py-evm that referenced this issue May 3, 2019
@carver
Remove TODO in favor of issue ethereum#1774
2ecfe3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carver