Use specific hardhat version on openzeppelin and gp2 external tests #14938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0qs
force-pushed
the
cancun-fix-zeppelin-gp2-tests
branch
from
acf3512 to
8dc0094
Compare
cameel
previously approved these changes
Mar 13, 2024
r0qs
force-pushed
the
cancun-fix-zeppelin-gp2-tests
branch
from
8dc0094 to
c5b438e
Compare
cameel
approved these changes
Mar 13, 2024
|
I'd be careful with auto-merge here. It will merge the PR even if non-required jobs fail. And the two you're changing are not required :) This should be merged only if it passes all the tests. |
|
Build is green across the board, so I'll be merging. |
Ruko97
pushed a commit
to Ruko97/solidity
that referenced
this pull request
Apr 7, 2024
Ruko97
pushed a commit
to Ruko97/solidity
that referenced
this pull request
Oct 20, 2024
Ruko97
pushed a commit
to Ruko97/solidity
that referenced
this pull request
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can enable those external tests in the CI again