Skip to content

Update emscripten docker image version #15693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

clonker
Copy link
Member

@clonker clonker commented Jan 6, 2025

Depends on PR #15691

@clonker clonker added the has dependencies The PR depends on other PRs that must be merged first label Jan 6, 2025
@clonker clonker force-pushed the update_docker_image_hashes branch from 0c90d3f to 97c0ae3 Compare January 6, 2025 12:59
@clonker clonker changed the base branch from develop to boost_download_location January 6, 2025 13:00
@clonker clonker force-pushed the update_docker_image_hashes branch from 97c0ae3 to f831664 Compare January 6, 2025 13:00
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the build_emscripten.sh

@clonker clonker force-pushed the update_docker_image_hashes branch from f831664 to 6af8bec Compare January 6, 2025 13:40
r0qs
r0qs previously approved these changes Jan 6, 2025

This comment was marked as resolved.

@ekpyron
Copy link
Member

ekpyron commented Jan 6, 2025

solbuildpackpusher/solidity-buildpack-deps:emscripten-20 [solbuildpackpusher/solidity-buildpack-deps@sha256:95814b6b7de5f72af357171eaafa8a8776104e16765393e22c1b1fe99a4bfe4a].

What, where did this come from :-D?

Base automatically changed from boost_download_location to develop January 6, 2025 14:13
@clonker clonker dismissed r0qs’s stale review January 6, 2025 14:13

The base branch was changed.

@clonker clonker merged commit 4939330 into develop Jan 6, 2025
73 checks passed
@clonker clonker deleted the update_docker_image_hashes branch January 6, 2025 14:22
@r0qs
Copy link
Member

r0qs commented Jan 6, 2025

solbuildpackpusher/solidity-buildpack-deps:emscripten-20 [solbuildpackpusher/solidity-buildpack-deps@sha256:95814b6b7de5f72af357171eaafa8a8776104e16765393e22c1b1fe99a4bfe4a].

What, where did this come from :-D?

It is because this brach was rebase on top of the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependencies The PR depends on other PRs that must be merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants