-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add Cyfrin's glossary to Resources in the docs #16081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
Ping @mehtavishwa30. |
b98c562
to
aa4d55b
Compare
@mehtavishwa30 This needs a rebase and squashing. I think you used the "Update branch" feature to do it, but without switching it to "rebase". If you do that, it creates a merge commit (which we do not want). |
@cameel got it. it also has some failing checks. What are those about? |
There seems to be some new rate-limiting going on with our Foundry version check and that makes a lot of external test jobs fail. They're unrelated to the PR and they're not required checks so you can ignore them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rebase and merge.
e467a34
to
0e8ac1b
Compare
Well, seems like a few required tests are failing now. @cameel will wait for you to check those before rebasing and merging. |
It's already reabased and fine to merge, but there seems to be something weird happening on CircleCI side. All of these jobs should not be failing. |
I can make a new PR if that's easier |
853cf9d
to
0e8ac1b
Compare
0e8ac1b
to
47e0335
Compare
Maybe it would have been easier after all, it seems like the commit was borked somehow or at least the circleci cache for it was borked. :D Anyways, I've performed some git surgery git reset --soft HEAD~1
git commit --author="Patrick Collins <[email protected]>" -m "feat: added updraft glossary for solidity and smart contract terms" --date="Mon Jun 9 09:50:22 2025 -0400"
git push --force-with-lease tmp feat/updraft-addition where |
Well, when pushing the squashed commit I first accidentally pushed it as a branch named It's just very unintuitive that CircleCI gets confused by something like this. The way I understand it, the checks are supposed to be connected with a branch, not with a commit. But I guess they must be doing some caching to avoid rerunning multiple times on the same commit and that breaks this mental model in unexpected ways. |
We have a glossary with many of the terms taught in Cyfrin Updraft.
https://www.cyfrin.io/glossary
Figured it would be a good resource to add!
(Note: It's different from what's in #15339)