Update ConsenSys StandardToken.sol reference link to current GitHub location #16087
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-matic
force-pushed
the
fix-broken-link
branch
from
b89a633 to
747afa8
Compare
cameel
reviewed
Jun 18, 2025
| @@ -23,7 +23,7 @@ corresponding approval process. Tokens need to be created by a derived | |||
| contract (e.g. TokenCreation.sol). | |||
|
|
|||
| Thank you ConsenSys, this contract originated from: | |||
| https://github.com/ConsenSys/Tokens/blob/master/Token_Contracts/contracts/Standard_Token.sol | |||
| https://github.com/ConsenSys/Token-Factory/blob/master/contracts/StandardToken.sol | |||
There was a problem hiding this comment.
Are you sure this is the right link or are you assuming just based on the names?
Comparing even the earliest versions I can find in the repos, they're quite different in terms of implementation - different modifiers, events, inheritance structure:
- https://github.com/ethereum/solidity/blob/8adde5abbe13b015b625862e3657d109ae6a48b5/test/externalTests/solc-js/DAO/Token.sol
- https://github.com/Consensys/Token-Factory/blob/a23e2d9b146a95915dea2b04b087efc1f50896b8/contracts/Standard_Token.sol
If it's not certain, I'd rather leave the link as is, even if it's broken. It's more accurate since that's where the code came from and will be more helpful than a wrong link if anyone ever needs to track down the actual source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the outdated ConsenSys Standard_Token.sol GitHub URL in the Token.sol file header with the current valid link:
https://github.com/ConsenSys/Token-Factory/blob/master/contracts/StandardToken.sol
This ensures that future readers and developers are directed to the correct source for the standard token contract reference.