This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Swap metrics reporter #1004
Closed
Swap metrics reporter #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holisticode
commented
Nov 16, 2018
nonsense
reviewed
Nov 19, 2018
nonsense
reviewed
Nov 19, 2018
nonsense
reviewed
Nov 19, 2018
nonsense
reviewed
Nov 19, 2018
nonsense
reviewed
Nov 19, 2018
nonsense
reviewed
Nov 19, 2018
| return nil, err | ||
| } | ||
| self.swap = swap.New(balancesStore) | ||
| self.metricsStore = protocols.SetupAccountingMetrics(10*time.Second, filepath.Join(config.Path, "metrics.db")) |
There was a problem hiding this comment.
I think SetupAccountingMetrics is doing too many things - creating/loading the db into the registry and also firing up the reporter (currently set to every 10 seconds.). We should probably think about splitting this up, but it also works as is.
There was a problem hiding this comment.
It's actually NewAccountingMetrics that is doing both things, so I vote for keeping SetupAccountingMetrics as is
nonsense
reviewed
Nov 19, 2018
|
Closed by ethereum/go-ethereum#18136 which is the actual upstream PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces metrics persistence to p2p accounting.
This PR is only for review and will be opened on the ethereum repo